Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbdCTLCk (ORCPT ); Mon, 20 Mar 2017 07:02:40 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:56805 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836AbdCTLBf (ORCPT ); Mon, 20 Mar 2017 07:01:35 -0400 Message-ID: <1490007648.2917.41.camel@pengutronix.de> Subject: Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling From: Philipp Zabel To: Andrzej Hajda Cc: linux-mmc@vger.kernel.org, Jaehoon Chung , Ulf Hansson , linux-kernel@vger.kernel.org, "Szyprowski, Marek" , Bartlomiej Zolnierkiewicz , linux-samsung-soc Date: Mon, 20 Mar 2017 12:00:48 +0100 In-Reply-To: <5f6c8c58-c4e4-39e6-2c29-e889bd6bf565@samsung.com> References: <20170315113139.17989-1-p.zabel@pengutronix.de> <1490003602.2917.16.camel@pengutronix.de> <1490005679.2917.32.camel@pengutronix.de> <5f6c8c58-c4e4-39e6-2c29-e889bd6bf565@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 37 On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: > On 20.03.2017 11:27, Philipp Zabel wrote: [...] > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > index 86b4ed75359e8..c905ff1c21ec6 100644 > > --- a/include/linux/reset.h > > +++ b/include/linux/reset.h > > @@ -74,14 +74,14 @@ static inline struct reset_control *__of_reset_control_get( > > const char *id, int index, bool shared, > > bool optional) > > { > > - return ERR_PTR(-ENOTSUPP); > > + return optional ? NULL : ERR_PTR(-ENOTSUPP); > > } > > > > static inline struct reset_control *__devm_reset_control_get( > > struct device *dev, const char *id, > > int index, bool shared, bool optional) > > { > > - return ERR_PTR(-ENOTSUPP); > > + return optional ? NULL : ERR_PTR(-ENOTSUPP); > > } > > > > #endif /* CONFIG_RESET_CONTROLLER */ > > ---------->8---------- > > In dw_mmc.c file there are also unconditional calls to > reset_control_assert, with disabled RESET_CONTROLLER it will cause > unexpected WARNs. > Anyway if you change reset API as above I think you should remove all > warns from reset stubs, because NULL reset is valid, but these warns are > there for reason - contradiction. You are right, I have to let go of those, too. regards Philipp