Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263455AbTEYQPb (ORCPT ); Sun, 25 May 2003 12:15:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263510AbTEYQPb (ORCPT ); Sun, 25 May 2003 12:15:31 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:40100 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S263455AbTEYQPb (ORCPT ); Sun, 25 May 2003 12:15:31 -0400 Date: Sun, 25 May 2003 18:28:44 +0200 From: Jens Axboe To: "Paulo Andre'" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Check copy_*_user return value in drivers/block/scsi_ioctl.c Message-ID: <20030525162844.GJ812@suse.de> References: <20030525172549.7df834f9.fscked@iol.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030525172549.7df834f9.fscked@iol.pt> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 19 On Sun, May 25 2003, Paulo Andre' wrote: > Hi Jens, > > Please find attached a trivial patch that checks both > copy_to_user() and copy_from_user() returns values in scsi_ioctl.c, > returning accordinly in case of a transfer error. See above, we've already done access_ok() on the buffer so the "unchecked" copy_to/from_user are done that way on purpose. I suppose it could be made more explicit with __copy_to/from_user(). -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/