Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754551AbdCTLPE (ORCPT ); Mon, 20 Mar 2017 07:15:04 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:35194 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754540AbdCTLPC (ORCPT ); Mon, 20 Mar 2017 07:15:02 -0400 Date: Mon, 20 Mar 2017 10:47:37 +0000 From: Lee Jones To: Tony Lindgren Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Marcel Partap , Michael Scott , Sebastian Reichel Subject: Re: [PATCH 4/4] mfd: cpcap: Fix bad use of IRQ sense register Message-ID: <20170320104737.fzrjyzbq77xlyl5d@dell> References: <20170317003633.7361-1-tony@atomide.com> <20170317003633.7361-5-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170317003633.7361-5-tony@atomide.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 36 On Thu, 16 Mar 2017, Tony Lindgren wrote: > The cpcap INTS registers are for getting the value of the line, > not for configuring the type. > > Cc: Lee Jones > Cc: Marcel Partap > Cc: Michael Scott > Cc: Sebastian Reichel > Signed-off-by: Tony Lindgrne Please resubmit with acquired Acks and your name spelt correctly. Acked-by: Lee Jones > --- > drivers/mfd/motorola-cpcap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c > --- a/drivers/mfd/motorola-cpcap.c > +++ b/drivers/mfd/motorola-cpcap.c > @@ -115,7 +115,6 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = { > .status_base = CPCAP_REG_INT1, > .ack_base = CPCAP_REG_INT1, > .mask_base = CPCAP_REG_INTM1, > - .type_base = CPCAP_REG_INTS1, > .use_ack = true, > .handle_reread = true, > .ack_invert = true, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog