Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbdCTMYZ (ORCPT ); Mon, 20 Mar 2017 08:24:25 -0400 Received: from mail-ot0-f180.google.com ([74.125.82.180]:34135 "EHLO mail-ot0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbdCTMXv (ORCPT ); Mon, 20 Mar 2017 08:23:51 -0400 MIME-Version: 1.0 In-Reply-To: <20170320134414.25f2e3d6@canb.auug.org.au> References: <20170320134414.25f2e3d6@canb.auug.org.au> From: Arnd Bergmann Date: Mon, 20 Mar 2017 13:23:49 +0100 X-Google-Sender-Auth: yP0Pe7v1TMFILcD9dHK26eZ1ixg Message-ID: Subject: Re: linux-next: build failure after merge of the char-misc tree To: Stephen Rothwell Cc: Greg KH , linux-next@vger.kernel.org, Linux Kernel Mailing List , Cyril Bur , Joel Stanley , Benjamin Herrenschmidt Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1569 Lines: 33 On Mon, Mar 20, 2017 at 3:44 AM, Stephen Rothwell wrote: > Hi all, > > After merging the char-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/misc/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_mmap': > drivers/misc/aspeed-lpc-ctrl.c:51:9: error: implicit declaration of function 'pgprot_dmacoherent' [-Werror=implicit-function-declaration] > prot = pgprot_dmacoherent(prot); A lot of other drivers (including /dev/mem) just use pgprot_noncached() or pgprot_writecombine(), which would make the code portable and might be what you want here as well. pgprot_dmacoherent() is meant specifically for mapping RAM that is used for DMA buffers that come from dma_alloc_coherent(), which doesn't seem to be the case here. What kind of address range is this really? > drivers/misc/aspeed-lpc-ctrl.c:51:7: error: incompatible types when assigning to type 'pgprot_t {aka struct pgprot}' from type 'int' > prot = pgprot_dmacoherent(prot); > ^ > In file included from include/linux/miscdevice.h:6:0, > from drivers/misc/aspeed-lpc-ctrl.c:11: > drivers/misc/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': > drivers/misc/aspeed-lpc-ctrl.c:232:17: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'phys_addr_t {aka long long unsigned int}' [-Wformat=] > dev_info(dev, "Loaded at 0x%08x (0x%08x)\n", This should just use the "%pap" for printing a phys_addr_t, otherwise we get the same warning on ARM in some configurations. Arnd