Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754675AbdCTMad (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Mar 2017 08:30:33 -0400
Received: from relay1.mentorg.com ([192.94.38.131]:39856 "EHLO
        relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754254AbdCTMaE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Mar 2017 08:30:04 -0400
Subject: Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode
To: Nickey Yang <nickey.yang@rock-chips.com>, <architt@codeaurora.org>,
        <airlied@linux.ie>
References: <1489978651-16647-1-git-send-email-nickey.yang@rock-chips.com>
CC: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <linux-rockchip@lists.infradead.org>, <dianders@chromium.org>,
        <laurent.pinchart+renesas@ideasonboard.com>, <joabreu@synopsys.com>,
        <andy.yan@rock-chips.com>, <zhengyang@rock-chips.com>,
        <rmk+kernel@arm.linux.org.uk>
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Message-ID: <4484b511-5d89-4c46-3847-4f40ade79e98@mentor.com>
Date: Mon, 20 Mar 2017 13:55:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <1489978651-16647-1-git-send-email-nickey.yang@rock-chips.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [137.202.0.87]
X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To
 SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1009
Lines: 32

Hi Nickey,

On 03/20/2017 04:57 AM, Nickey Yang wrote:
> "I2C Master Interface Extended Read Mode" implements a segment
> pointer-based read operation using the Special Register configuration.
> 
> This patch fix https://patchwork.kernel.org/patch/7098101/ mentioned
> "The current implementation does not support "I2C Master Interface
> Extended Read Mode" to read data addressed by non-zero segment
> pointer, this means that if EDID has more than 1 extension blocks"

... EDID reading operation won't succeed.

Indeed.

> 
> With this patch,dw-hdmi can read EDID data with 1/2/4 blocks.
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---

Unfortunately I don't have a chance to test the change thoroughly, but
from what I see the implementation is correct. Thank you for the change.

Please feel free to update the commit message and add my

Acked-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>

--
With best wishes,
Vladimir