Date: Mon, 20 Mar 2017 13:42:17 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Antonio Borneo <borneo.antonio@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Viresh Kumar <vireshk@kernel.org>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Brijesh Singh <brijeshkumar.singh@amd.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] spi: pl022: remove nonexistent properties from DT
 binding example
Message-ID: <20170320134217.GB31213@leverpostej>
References: <20170320095721.6724-1-borneo.antonio@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170320095721.6724-1-borneo.antonio@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1590
Lines: 47

On Mon, Mar 20, 2017 at 10:57:18AM +0100, Antonio Borneo wrote:
> The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were
> initially proposed till patch V4 [1] but then discarded in V5 [2]
> when the patch set was taken over by another developer, as
> explained in patch history in [3].
> The above properties never landed in mainline code but were then
> listed in the binding example by a following commit dc715452e914
> ("spi: pl022: use generic DMA slave configuration if possible")
> and later on they were copy-paste in some board's DT.
> 
> Remove the nonexistent properties from the example.
> Also remove a spaces-only line at the end of the file.
> 
> [1] https://lkml.org/lkml/2012/7/9/421
> [2] https://lkml.org/lkml/2012/8/21/427
> [3] https://lkml.org/lkml/2012/8/21/436
> 
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>

For the series:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
> index 4d1673ca8cf8..2692a5726c3f 100644
> --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -56,9 +56,7 @@ Example:
>  			spi-max-frequency = <12000000>;
>  			spi-cpol;
>  			spi-cpha;
> -			pl022,hierarchy = <0>;
>  			pl022,interface = <0>;
> -			pl022,slave-tx-disable;
>  			pl022,com-mode = <0x2>;
>  			pl022,rx-level-trig = <0>;
>  			pl022,tx-level-trig = <0>;
> @@ -67,4 +65,3 @@ Example:
>  			pl022,duplex = <0>;
>  		};
>  	};
> -	
> -- 
> 2.12.0
>