Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755223AbdCTOOi (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Mar 2017 10:14:38 -0400
Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:43673 "EHLO
        mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1755195AbdCTOOb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Mar 2017 10:14:31 -0400
Authentication-Results: ppops.net;
        spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com
Date: Mon, 20 Mar 2017 14:14:07 +0000
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Ryan Lee <ryans.lee@maximintegrated.com>
CC: <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <perex@perex.cz>, <tiwai@suse.com>,
        <kuninori.morimoto.gx@renesas.com>, <arnd@arndb.de>, <lars@metafoo.de>,
        <bardliao@realtek.com>, <nh6z@nh6z.net>, <KCHSU0@nuvoton.com>,
        <axel.lin@ingics.com>, <romain.perier@collabora.com>, <petr@barix.com>,
        <srinivas.kandagatla@linaro.org>, <oder_chiou@realtek.com>,
        <Paul.Handrigan@cirrus.com>, <alsa-devel@alsa-project.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dgreid@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for Maxim Integrated
 MAX98927 Amplifier
Message-ID: <20170320141407.GS6986@localhost.localdomain>
References: <1489970423-29353-1-git-send-email-ryans.lee@maximintegrated.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1489970423-29353-1-git-send-email-ryans.lee@maximintegrated.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0
 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011
 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703200124
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1786
Lines: 52

On Mon, Mar 20, 2017 at 09:40:23AM +0900, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
> Resubmit the intial version of MAX98927 driver. Added all fixes into the initial patch.
<snip>
> +static int max98927_reg_get(struct snd_kcontrol *kcontrol,
> +	struct snd_ctl_elem_value *ucontrol, unsigned int reg,
> +	unsigned int mask, unsigned int shift)
> +{
> +	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
> +	struct max98927_priv *max98927 = snd_soc_codec_get_drvdata(codec);
> +	int data;
> +
> +	regmap_read(max98927->regmap, reg, &data);
> +	ucontrol->value.integer.value[0] = (data & mask) >> shift;
> +	return 0;
> +}
> +
> +static int max98927_reg_put(struct snd_kcontrol *kcontrol,
> +	struct snd_ctl_elem_value *ucontrol, unsigned int reg,
> +	unsigned int mask, unsigned int shift)
> +{
> +	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
> +	struct max98927_priv *max98927 = snd_soc_codec_get_drvdata(codec);
> +	unsigned int sel = ucontrol->value.integer.value[0];
> +
> +	regmap_update_bits(max98927->regmap, reg, mask, sel << shift);
> +	dev_dbg(codec->dev, "%s: register 0x%02X, value 0x%02X\n",
> +		__func__, reg, sel);
> +	return 0;
> +}

These functions look a lot like they duplicate things the ASoC
core does?

<snip>
> +static int max98927_boost_voltage_get(struct snd_kcontrol *kcontrol,
> +	struct snd_ctl_elem_value *ucontrol)
> +{
> +	return max98927_reg_get(kcontrol, ucontrol,
> +		MAX98927_R0040_BOOST_CTRL0,
> +		MAX98927_BOOST_CTRL0_VOUT_MASK, 0);
> +}
> +

And can't these just be specified in the normal way with the
register information attached to the control? There doesn't seem
to be any special behaviour being added here. Apologies if I am
missing something here.

Thanks,
Charles