Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbdCTOlN (ORCPT ); Mon, 20 Mar 2017 10:41:13 -0400 Received: from muru.com ([72.249.23.125]:40792 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753545AbdCTOja (ORCPT ); Mon, 20 Mar 2017 10:39:30 -0400 Date: Mon, 20 Mar 2017 07:33:09 -0700 From: Tony Lindgren To: Arnd Bergmann Cc: Sebastian Reichel , Liam Breck , Mark Greer , Colin Ian King , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused Message-ID: <20170320143309.GF20572@atomide.com> References: <20170320131424.271241-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320131424.271241-1-arnd@arndb.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 15 * Arnd Bergmann [170320 06:17]: > Without CONFIG_PM, we get a harmless warning: > > drivers/power/supply/bq24190_charger.c:1514:12: error: 'bq24190_runtime_resume' defined but not used [-Werror=unused-function] > drivers/power/supply/bq24190_charger.c:1501:12: error: 'bq24190_runtime_suspend' defined but not used [-Werror=unused-function] > > To avoid the warning, we can mark all four PM functions as __maybe_unused, > which also lets us remove the incorrect #ifdef. > > Fixes: 3d8090cba638 ("power: bq24190_charger: Check the interrupt status on resume") > Signed-off-by: Arnd Bergmann Thanks for fixing that: Acked-by: Tony Lindgren