Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbdCTPOm (ORCPT ); Mon, 20 Mar 2017 11:14:42 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:58948 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbdCTPNX (ORCPT ); Mon, 20 Mar 2017 11:13:23 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Mon, 20 Mar 2017 15:14:13 +0000 From: Charles Keepax To: Tony Lindgren CC: Mark Brown , , , Lee Jones , Marcel Partap , Michael Scott , "Sebastian Reichel" Subject: Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread Message-ID: <20170320151413.GT6986@localhost.localdomain> References: <20170317003633.7361-1-tony@atomide.com> <20170317003633.7361-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170317003633.7361-2-tony@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703200131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 16 On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. > > Let's allow doing that by introducing a flag for handle_reread > and by splitting regmap_irq_thread() into two separate functions > for regmap_read_irq_status() and regmap_irq_handle_pending(). > Is this actually a property of this hardware or is this just a result of connecting a device that generates level IRQs to a host that is expecting an edge triggered IRQ? Thanks, Charles