Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755004AbdCTQIP (ORCPT ); Mon, 20 Mar 2017 12:08:15 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39760 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100AbdCTQH0 (ORCPT ); Mon, 20 Mar 2017 12:07:26 -0400 Date: Mon, 20 Mar 2017 16:06:22 +0000 From: Mark Brown To: Kai-Heng Feng Cc: lgirdwood@gmail.com, bardliao@realtek.com, oder_chiou@realtek.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20170320160622.5s2oqdyluvanjp2u@sirena.org.uk> References: <20170320035831.10762-1-kai.heng.feng@canonical.com> <20170320150845.7rltrhycdkk2mza4@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5hpmpyjvodvhy35f" Content-Disposition: inline In-Reply-To: X-Cookie: No shirt, no shoes, no service. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2301 Lines: 62 --5hpmpyjvodvhy35f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 20, 2017 at 03:46:13PM +0000, Kai-Heng Feng wrote: > On Mon, Mar 20, 2017 at 11:08 PM Mark Brown wrote: > > As covered in SubmittingPatches this should come after the ---, it > > doesn't need to end up in the changelogs. > Do you mean > https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L197 > ? > I didn't find any hard rules regarding this, but I'll keep it in mind. As it says there "...and inserted automatically following the three dash line". > > > SND_SOC_DAPM_POST_PMD: + case SND_SOC_DAPM_POST_PMU: + > > > snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE); + > > > break; + case SND_SOC_DAPM_PRE_PMU: Please fix your mail client not to completely mangle quoted patches when replying. > > To repeat what I said last time: > > | After power up we mute the amplifier? That's worthy of a > > comment... > IIUC, HPO Power's _POST_PMU is triggered right before power down > (_PRE_PMD), hence it's pretty logical to mute the amplifier at this > stage. I can't quite see anything wrong here. No, that is not the case - I'm not sure what would lead you to believe that it is. _POST_PMU is triggered as the last step of powering up the widget as the name might suggest. Has this code been tested at all? > So no I didn't ignore your comment, I simply misinterpreted what you > meant. Because of the logical assumption, I thought you were talking > the unmute part in _PRE_PMU, which I did add in the changelog. You didn't reply to my review comment and you sent the same code again. That looks an awful lot like being ignored. --5hpmpyjvodvhy35f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljP/f0ACgkQJNaLcl1U h9CUaQf+Kq10Pg5K+iAUUHpLuOQAw+7JkEOGTCwJv2aOaEYy6yC8t5jT4dViIhdv 1AMDHjKhPfvKA9tpa8DH3RquRIIkT/qQDh1/MaodrM3Q5Pl5dwk5EHJa7HJW2n7M Um8uJrORrVmcuRV1FPcGltooOMB+CN52UiH2Wrb0TbryvN9f0uTPbbPBgLs4PjNo w+yl1LlON8+TmxDDfJakl0EEzgCnTjsF1Cp2bh4UTgXSnEmjIj14qHy87XUidDJk yYj9OCfRDm4RgYoIk/T/Wxk7sosf5Knrn734PH5C/pg9UAxzVuH+3PvBB1pgnd5y slgxURVRWSYgIq5jkZkWYWseA+02bQ== =hcTK -----END PGP SIGNATURE----- --5hpmpyjvodvhy35f--