Date: Sun, 25 May 2003 21:00:28 -0400 (EDT)
From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: Jeff Garzik <jgarzik@pobox.com>
cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@digeo.com>
Subject: Re: [PATCH] xirc2ps_cs irq return fix
In-Reply-To: <3ED16351.7060904@pobox.com>
Message-ID: <Pine.LNX.4.50.0305252051570.28320-100000@montezuma.mastecende.com>
References: <200305252318.h4PNIPX4026812@hera.kernel.org> <3ED16351.7060904@pobox.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 24

On Sun, 25 May 2003, Jeff Garzik wrote:

> As I mentioned in the thread, this piece of code is obviously wrong.
> 
> Think about how scalable this fix is??  Do you really want to crap up 
> all pcmcia drivers with this silly -- and wrong -- check?

My interpretation of it is the PCMCIA controller was triggering interrupts 
on exit and the link handler for the card was still installed even after 
the netdevice was down.

> IIRC the pcmcia layer or new irqreturn_t was blamed for the problem. 
> Come on.  Linux mantra is -against- papering over bugs.

I have to take responsibility for that little mess :(

	Zwane
-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/