Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755850AbdCTQfv (ORCPT ); Mon, 20 Mar 2017 12:35:51 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36598 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755263AbdCTQfe (ORCPT ); Mon, 20 Mar 2017 12:35:34 -0400 Date: Tue, 21 Mar 2017 02:35:17 +1000 From: Nicholas Piggin To: "Gautham R. Shenoy" Cc: Michael Ellerman , Michael Neuling , Benjamin Herrenschmidt , "Shreyas B. Prabhu" , Shilpasri G Bhat , Vaidyanathan Srinivasan , Anton Blanchard , Balbir Singh , Akshay Adiga , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation from smp.c to idle.c Message-ID: <20170321023517.4cb27add@roar.ozlabs.ibm.com> In-Reply-To: <358fc68275a4986d2e112418aea447f49f644f7e.1490024477.git.ego@linux.vnet.ibm.com> References: <358fc68275a4986d2e112418aea447f49f644f7e.1490024477.git.ego@linux.vnet.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 17 On Mon, 20 Mar 2017 21:24:15 +0530 "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > Move the piece of code in powernv/smp.c::pnv_smp_cpu_kill_self() which > transitions the CPU to the deepest available platform idle state to a > new function named pnv_cpu_offline() in powernv/idle.c. The rationale > behind this code movement is that the data required to determine the > deepest available platform state resides in powernv/idle.c. > > Signed-off-by: Gautham R. Shenoy Looks good. As a nitpick, possibly one or two variables in idle.c could become static (pnv_deepest_stop_psscr_*). Reviewed-by: Nicholas Piggin