Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932078AbdCTR1F (ORCPT ); Mon, 20 Mar 2017 13:27:05 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41216 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755833AbdCTR1D (ORCPT ); Mon, 20 Mar 2017 13:27:03 -0400 Date: Mon, 20 Mar 2017 17:26:47 +0000 From: Mark Brown To: Kai-Heng Feng Cc: Liam Girdwood , Bard Liao , Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20170320172647.t7qacxqcgawe7xlf@sirena.org.uk> References: <20170320035831.10762-1-kai.heng.feng@canonical.com> <20170320150845.7rltrhycdkk2mza4@sirena.org.uk> <20170320160622.5s2oqdyluvanjp2u@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="va442svrmrnoixzj" Content-Disposition: inline In-Reply-To: X-Cookie: No shirt, no shoes, no service. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1785 Lines: 50 --va442svrmrnoixzj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: > On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > > As it says there "...and inserted automatically following the three dash > > line". > I saw iteration changelog in git log all over the place, maybe add a > rule section for each subsystem? Some people won't push back, the only people who insist on anything different are the graphics people. > I had the same thought originally, but printk under each case suggests > otherwise - _POST_PMU is triggered not right after _PRE_PMU but right > before _PRE_PMD. Then you've broken something else on your system, that is obviously completely nonsensical and would break anything that relies on having a _POST_PMU event. Why would we have two events that run at the same time one of which is obviously misnamed? > > > You didn't reply to my review comment and you sent the same code > > > again. > > That looks an awful lot like being ignored. > Fair enough, I thought changelog is sufficient. I'm not seeing anything in the changelog that addresses this. --va442svrmrnoixzj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljQENcACgkQJNaLcl1U h9DTbwf/dBQUnftyISbcXK2n6NRRXtTm4tY7ksva5QB0g1UqkDF8XdscDCNZ41ax ovOqCMqPJk92NZgjCnvqAYInhgbH9c3us1CDwLr0+Q55/l1kBr/zHUVoOyVFpLCX L8NL/gmELjHiHUlJoeXG7qtDmFcOTlZ1ghMeDkvckMYaEEsZxdwY4fFMyyQzBLBj n0Y4xBQEW55gz4l19eRNKkslz1Lfr4HeCvO3rTllfrfCiiF3/iPPfLIyIxpMXOk/ wpyfrIl0ng88q2EC/fp6ZZQuNLRGdrtQ/JROGpvd5bv//bSToDOhw4acx5DGjt1E ArmR3TFHblg6tZpIcs7LsI+bBLcYHA== =aais -----END PGP SIGNATURE----- --va442svrmrnoixzj--