Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755520AbdCTRmc (ORCPT ); Mon, 20 Mar 2017 13:42:32 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:57179 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753264AbdCTRmb (ORCPT ); Mon, 20 Mar 2017 13:42:31 -0400 Subject: Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe To: Niklas Cassel , References: <20170320172915.8313-1-niklass@axis.com> CC: , , , , Niklas Cassel From: Joao Pinto Message-ID: Date: Mon, 20 Mar 2017 17:42:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170320172915.8313-1-niklass@axis.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.117] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 24 ?s 5:29 PM de 3/20/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up > > However, stmmac returns -EBUSY if !netif_running. > The only reason for this appears to be that stmmac_init_phy > is called from stmmac_open instead of from stmmac_dvr_probe. > > Move stmmac_init_phy to stmmac_dvr_probe so that ethool > works as soon as register_netdev has been called. > stmmac_check_ether_addr was also moved to probe, > so that the ordering doesn't change. > > Signed-off-by: Niklas Cassel > --- Hi Niklas, did you test this patch? Thanks. Joao