Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756171AbdCTRyQ (ORCPT ); Mon, 20 Mar 2017 13:54:16 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:39755 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755284AbdCTRyL (ORCPT ); Mon, 20 Mar 2017 13:54:11 -0400 Subject: Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe To: Joao Pinto References: <20170320172915.8313-1-niklass@axis.com> CC: , , , From: Niklas Cassel Message-ID: <5921fa33-5509-a158-80d6-acda7e68b418@axis.com> Date: Mon, 20 Mar 2017 18:44:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX02.axis.com (10.0.5.16) To XBOX02.axis.com (10.0.5.16) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 25 On 03/20/2017 06:42 PM, Joao Pinto wrote: > ?s 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >> From: Niklas Cassel >> >> It is usually possible to do >> ethtool -s autoneg on >> so that you trigger an autoneg before calling >> ip link set dev eth0 up >> >> However, stmmac returns -EBUSY if !netif_running. >> The only reason for this appears to be that stmmac_init_phy >> is called from stmmac_open instead of from stmmac_dvr_probe. >> >> Move stmmac_init_phy to stmmac_dvr_probe so that ethool >> works as soon as register_netdev has been called. >> stmmac_check_ether_addr was also moved to probe, >> so that the ordering doesn't change. >> >> Signed-off-by: Niklas Cassel >> --- > Hi Niklas, did you test this patch? I tested it on our hardware, but it would be nice if you could test it on your side, since you are using the PCI glue layer.