Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756786AbdCTSLD (ORCPT ); Mon, 20 Mar 2017 14:11:03 -0400 Received: from mail-ua0-f172.google.com ([209.85.217.172]:35505 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755548AbdCTSK6 (ORCPT ); Mon, 20 Mar 2017 14:10:58 -0400 MIME-Version: 1.0 In-Reply-To: <1490007648.2917.41.camel@pengutronix.de> References: <20170315113139.17989-1-p.zabel@pengutronix.de> <1490003602.2917.16.camel@pengutronix.de> <1490005679.2917.32.camel@pengutronix.de> <5f6c8c58-c4e4-39e6-2c29-e889bd6bf565@samsung.com> <1490007648.2917.41.camel@pengutronix.de> From: Ulf Hansson Date: Mon, 20 Mar 2017 19:10:56 +0100 Message-ID: Subject: Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling To: Philipp Zabel Cc: Andrzej Hajda , "linux-mmc@vger.kernel.org" , Jaehoon Chung , "linux-kernel@vger.kernel.org" , "Szyprowski, Marek" , Bartlomiej Zolnierkiewicz , linux-samsung-soc Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 47 On 20 March 2017 at 12:00, Philipp Zabel wrote: > On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote: >> On 20.03.2017 11:27, Philipp Zabel wrote: > [...] >> > diff --git a/include/linux/reset.h b/include/linux/reset.h >> > index 86b4ed75359e8..c905ff1c21ec6 100644 >> > --- a/include/linux/reset.h >> > +++ b/include/linux/reset.h >> > @@ -74,14 +74,14 @@ static inline struct reset_control *__of_reset_control_get( >> > const char *id, int index, bool shared, >> > bool optional) >> > { >> > - return ERR_PTR(-ENOTSUPP); >> > + return optional ? NULL : ERR_PTR(-ENOTSUPP); >> > } >> > >> > static inline struct reset_control *__devm_reset_control_get( >> > struct device *dev, const char *id, >> > int index, bool shared, bool optional) >> > { >> > - return ERR_PTR(-ENOTSUPP); >> > + return optional ? NULL : ERR_PTR(-ENOTSUPP); >> > } >> > >> > #endif /* CONFIG_RESET_CONTROLLER */ >> > ---------->8---------- >> >> In dw_mmc.c file there are also unconditional calls to >> reset_control_assert, with disabled RESET_CONTROLLER it will cause >> unexpected WARNs. >> Anyway if you change reset API as above I think you should remove all >> warns from reset stubs, because NULL reset is valid, but these warns are >> there for reason - contradiction. > > You are right, I have to let go of those, too. Until fixed, I have dropped the three changes from my next branch related to this. Please re-post when fixed. Kind regards Uffe > > regards > Philipp >