Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756943AbdCTSLl (ORCPT ); Mon, 20 Mar 2017 14:11:41 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:34157 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756825AbdCTSLe (ORCPT ); Mon, 20 Mar 2017 14:11:34 -0400 MIME-Version: 1.0 In-Reply-To: <1489692253-20299-1-git-send-email-linux@roeck-us.net> References: <1489692253-20299-1-git-send-email-linux@roeck-us.net> From: Doug Anderson Date: Mon, 20 Mar 2017 11:03:51 -0700 X-Google-Sender-Auth: 7ANZe6CwytSSVGUtbfMFTLBPlcc Message-ID: Subject: Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors To: Guenter Roeck Cc: Greg Kroah-Hartman , Alan Stern , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Brian Norris Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 20 Hi, On Thu, Mar 16, 2017 at 12:24 PM, Guenter Roeck wrote: > @@ -1198,7 +1201,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type) > > /* Scan all ports that need attention */ > kick_hub_wq(hub); > - > +abort: One tiny nit that could be done when applying this patch is to add a space before "abort". Other goto labels in this function are preceded by a space and it's sane to try to match the existing coding convention in the function rather than trying to mix and match. Other than that this patch seems sane to me, but I am by no means an expert on this code. ;) -Doug