Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756230AbdCTSaW (ORCPT ); Mon, 20 Mar 2017 14:30:22 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:32998 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755873AbdCTSaT (ORCPT ); Mon, 20 Mar 2017 14:30:19 -0400 MIME-Version: 1.0 In-Reply-To: <20170320131424.271241-1-arnd@arndb.de> References: <20170320131424.271241-1-arnd@arndb.de> From: Liam Breck Date: Mon, 20 Mar 2017 11:29:25 -0700 X-Google-Sender-Auth: AviW6ge5P-7qlpn0F7byc92pFeA Message-ID: Subject: Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused To: Arnd Bergmann Cc: Sebastian Reichel , Tony Lindgren , Mark Greer , Colin Ian King , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2782 Lines: 72 On Mon, Mar 20, 2017 at 6:14 AM, Arnd Bergmann wrote: > Without CONFIG_PM, we get a harmless warning: > > drivers/power/supply/bq24190_charger.c:1514:12: error: 'bq24190_runtime_resume' defined but not used [-Werror=unused-function] > drivers/power/supply/bq24190_charger.c:1501:12: error: 'bq24190_runtime_suspend' defined but not used [-Werror=unused-function] > > To avoid the warning, we can mark all four PM functions as __maybe_unused, > which also lets us remove the incorrect #ifdef. > > Fixes: 3d8090cba638 ("power: bq24190_charger: Check the interrupt status on resume") > Signed-off-by: Arnd Bergmann Cool, thx! Acked-by: Liam Breck > --- > drivers/power/supply/bq24190_charger.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > index 6d80670586eb..451f2bc05ea5 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > @@ -1498,7 +1498,7 @@ static int bq24190_remove(struct i2c_client *client) > return 0; > } > > -static int bq24190_runtime_suspend(struct device *dev) > +static __maybe_unused int bq24190_runtime_suspend(struct device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > struct bq24190_dev_info *bdi = i2c_get_clientdata(client); > @@ -1511,7 +1511,7 @@ static int bq24190_runtime_suspend(struct device *dev) > return 0; > } > > -static int bq24190_runtime_resume(struct device *dev) > +static __maybe_unused int bq24190_runtime_resume(struct device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > struct bq24190_dev_info *bdi = i2c_get_clientdata(client); > @@ -1527,8 +1527,7 @@ static int bq24190_runtime_resume(struct device *dev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > -static int bq24190_pm_suspend(struct device *dev) > +static __maybe_unused int bq24190_pm_suspend(struct device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > struct bq24190_dev_info *bdi = i2c_get_clientdata(client); > @@ -1550,7 +1549,7 @@ static int bq24190_pm_suspend(struct device *dev) > return 0; > } > > -static int bq24190_pm_resume(struct device *dev) > +static __maybe_unused int bq24190_pm_resume(struct device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > struct bq24190_dev_info *bdi = i2c_get_clientdata(client); > @@ -1580,7 +1579,6 @@ static int bq24190_pm_resume(struct device *dev) > > return 0; > } > -#endif > > static const struct dev_pm_ops bq24190_pm_ops = { > SET_RUNTIME_PM_OPS(bq24190_runtime_suspend, bq24190_runtime_resume, > -- > 2.9.0 >