Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264292AbTEZF7i (ORCPT ); Mon, 26 May 2003 01:59:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264301AbTEZF7i (ORCPT ); Mon, 26 May 2003 01:59:38 -0400 Received: from blackbird.intercode.com.au ([203.32.101.10]:8465 "EHLO blackbird.intercode.com.au") by vger.kernel.org with ESMTP id S264292AbTEZF7g (ORCPT ); Mon, 26 May 2003 01:59:36 -0400 Date: Mon, 26 May 2003 16:12:34 +1000 (EST) From: James Morris To: Maciej Soltysiak cc: linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] make icmp.c be more verbose on broadcast icmp errors In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 31 On Fri, 23 May 2003, Maciej Soltysiak wrote: > if (net_ratelimit()) > printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP " > + "type %u, code %u " > "error to a broadcast.\n", > - NIPQUAD(skb->nh.iph->saddr)); > + NIPQUAD(skb->nh.iph->saddr), > + icmph->type, icmph->code); > if (net_ratelimit()) > - printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP error to a broadcast.\n", > - NIPQUAD(skb->nh.iph->saddr)); > + printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP type %u, code %u error to a broadcast.\n", > + NIPQUAD(skb->nh.iph->saddr), > + icmph->type, icmph->code); Perhaps make this a static inline, icmp_warn_invalid() or similar. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/