Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755961AbdCUBze (ORCPT ); Mon, 20 Mar 2017 21:55:34 -0400 Received: from condef-07.nifty.com ([202.248.20.72]:32012 "EHLO condef-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656AbdCUBzc (ORCPT ); Mon, 20 Mar 2017 21:55:32 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com v2L1oPvR013316 X-Nifty-SrcIP: [209.85.161.169] MIME-Version: 1.0 In-Reply-To: References: <1489754302-10996-1-git-send-email-piotrs@cadence.com> <1489754503-16559-1-git-send-email-piotrs@cadence.com> From: Masahiro Yamada Date: Tue, 21 Mar 2017 10:50:24 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration To: Piotr Sroka Cc: linux-mmc , Adrian Hunter , Ulf Hansson , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 29 Hi Piotr, 2017-03-20 17:47 GMT+09:00 Piotr Sroka : > >> >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev) >> > struct sdhci_cdns_priv *priv; >> > struct clk *clk; >> > int ret; >> > + struct device *dev = &pdev->dev; >> > >> > clk = devm_clk_get(&pdev->dev, NULL); >> >> >> If you add "dev", please use it for devm_clk_get, too. >> > I did on the first patch version but Ulf pointed that this is unrelated change and should be removed. > Therefore I remove it. Ah, OK. Could you consider to send a separate patch for this? -- Best Regards Masahiro Yamada