Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756052AbdCUCe4 (ORCPT ); Mon, 20 Mar 2017 22:34:56 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:39637 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755307AbdCUCey (ORCPT ); Mon, 20 Mar 2017 22:34:54 -0400 Subject: Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license To: Arnd Bergmann , Jie Deng References: <20170320085123.1032301-1-arnd@arndb.de> <20170320085123.1032301-2-arnd@arndb.de> CC: "David S. Miller" , , From: Jie Deng Message-ID: Date: Tue, 21 Mar 2017 10:34:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170320085123.1032301-2-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 30 On 2017/3/20 16:51, Arnd Bergmann wrote: > When building the driver as a module, we get a warning about the > lack of a license: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o > see include/linux/module.h for more information > > Curiously the text in the .c files only mentions GPLv2+, while the license > tag in the PCI driver contains both GPL and BSD. I picked the license text > as the more definite reference here and put a GPL tag in there. > > Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c > index 726d78ac4907..b72196ab647f 100644 > --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c > +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c > @@ -25,6 +25,7 @@ > > static int debug = -1; > module_param(debug, int, 0644); > +MODULE_LICENSE("GPL"); > MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)"); > static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN | > NETIF_MSG_IFUP); This driver uses dual license. I will update the headers to include BSD. Thanks!