Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932249AbdCUD4M (ORCPT ); Mon, 20 Mar 2017 23:56:12 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37949 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbdCUDz6 (ORCPT ); Mon, 20 Mar 2017 23:55:58 -0400 X-ME-Sender: X-Sasl-enc: 3ZgBDS9kZuya3/LDVod1zeXZ/LRbRYmLjbTevZCPQHW2 1490068556 Date: Mon, 20 Mar 2017 20:55:56 -0700 From: Mark Greer To: Arnd Bergmann Cc: Sebastian Reichel , Tony Lindgren , Liam Breck , Mark Greer , Colin Ian King , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused Message-ID: <20170321035556.GA17398@animalcreek.com> References: <20170320131424.271241-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320131424.271241-1-arnd@arndb.de> Organization: Animal Creek Technologies, Inc. User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 16 On Mon, Mar 20, 2017 at 02:14:15PM +0100, Arnd Bergmann wrote: > Without CONFIG_PM, we get a harmless warning: > > drivers/power/supply/bq24190_charger.c:1514:12: error: 'bq24190_runtime_resume' defined but not used [-Werror=unused-function] > drivers/power/supply/bq24190_charger.c:1501:12: error: 'bq24190_runtime_suspend' defined but not used [-Werror=unused-function] > > To avoid the warning, we can mark all four PM functions as __maybe_unused, > which also lets us remove the incorrect #ifdef. > > Fixes: 3d8090cba638 ("power: bq24190_charger: Check the interrupt status on resume") > Signed-off-by: Arnd Bergmann > --- Probably too late but if it isn't... Acked-by: Mark Greer