Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756216AbdCUFQ2 (ORCPT ); Tue, 21 Mar 2017 01:16:28 -0400 Received: from mail.kernel.org ([198.145.29.136]:53454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdCUFQ1 (ORCPT ); Tue, 21 Mar 2017 01:16:27 -0400 Date: Tue, 21 Mar 2017 14:08:41 +0900 From: Masami Hiramatsu To: Alexis Berlemont Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com Subject: Re: [PATCH v5 0/2] perf probe: add sdt probes arguments into the uprobe cmd string Message-Id: <20170321140841.b5ad642d76bc14ac16d1fdb2@kernel.org> In-Reply-To: <20161214000732.1710-1-alexis.berlemont@gmail.com> References: <20161207122610.008da636793d38a39accf29b@kernel.org> <20161214000732.1710-1-alexis.berlemont@gmail.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 49 Hello Alexis and Arnaldo, I think this series is now good to go. Could you pick these? Acked-by: Masami Hiramatsu for this series. Thank you, On Wed, 14 Dec 2016 01:07:30 +0100 Alexis Berlemont wrote: > Hi Masami, > > Many thanks for your mail. > > Here is another patch set which tries to fix the points you mentioned: > > * Skip the arguments containing a constant ($123); > * Review the code in charge of the register renaming (search for '%' > and parse it); > * Minor changes (print the argument in case of error, skipping, check > the sdt arg type index); > > Many thanks, > > Alexis. > > Alexis Berlemont (2): > perf sdt: add scanning of sdt probles arguments > perf probe: add sdt probes arguments into the uprobe cmd string > > tools/perf/arch/x86/util/perf_regs.c | 83 +++++++++++++++++ > tools/perf/util/perf_regs.c | 6 ++ > tools/perf/util/perf_regs.h | 6 ++ > tools/perf/util/probe-file.c | 170 ++++++++++++++++++++++++++++++++++- > tools/perf/util/symbol-elf.c | 25 +++++- > tools/perf/util/symbol.h | 1 + > 6 files changed, 285 insertions(+), 6 deletions(-) > > -- > 2.10.2 > -- Masami Hiramatsu