Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756366AbdCUFe3 (ORCPT ); Tue, 21 Mar 2017 01:34:29 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35233 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbdCUFeZ (ORCPT ); Tue, 21 Mar 2017 01:34:25 -0400 From: Viresh Kumar To: Stephen Warren , Thierry Reding , Alexandre Courbot Cc: linaro-kernel@lists.linaro.org, Viresh Kumar , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack Date: Tue, 21 Mar 2017 10:54:53 +0530 Message-Id: <3fe40fcd427e49cbeac31e14721fea569d230b6e.1490073884.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.12.0.432.g71c3a4f4ba37 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 55 The size of the struct tegra_powergate is quite big and if any more fields are added to the internal genpd structure, following warnings are thrown: drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] Avoid such warnings by allocating the structure dynamically. Signed-off-by: Viresh Kumar --- drivers/soc/tegra/pmc.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index e233dd5dcab3..c94196b939a4 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -557,22 +557,28 @@ EXPORT_SYMBOL(tegra_powergate_remove_clamping); int tegra_powergate_sequence_power_up(unsigned int id, struct clk *clk, struct reset_control *rst) { - struct tegra_powergate pg; + struct tegra_powergate *pg; int err; if (!tegra_powergate_is_available(id)) return -EINVAL; - pg.id = id; - pg.clks = &clk; - pg.num_clks = 1; - pg.resets = &rst; - pg.num_resets = 1; + pg = kzalloc(sizeof(*pg), GFP_KERNEL); + if (!pg) + return -ENOMEM; + + pg->id = id; + pg->clks = &clk; + pg->num_clks = 1; + pg->resets = &rst; + pg->num_resets = 1; - err = tegra_powergate_power_up(&pg, false); + err = tegra_powergate_power_up(pg, false); if (err) pr_err("failed to turn on partition %d: %d\n", id, err); + kfree(pg); + return err; } EXPORT_SYMBOL(tegra_powergate_sequence_power_up); -- 2.12.0.432.g71c3a4f4ba37