Message-ID: <1490080292.8236.99.camel@haakon3.risingtidesystems.com>
Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status
 request
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org, xypron.glpk@gmx.de,
        mnarani@xilinx.com, bart.vanassche@sandisk.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        anirudh@xilinx.com, svemula@xilinx.com,
        target-devel <target-devel@vger.kernel.org>
Date: Tue, 21 Mar 2017 00:11:32 -0700
In-Reply-To: <1490002529-24340-1-git-send-email-mnarani@xilinx.com>
References: <1490002529-24340-1-git-send-email-mnarani@xilinx.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1019
Lines: 30

Hi Manish,

(Added target-devel CC')

On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
> This patch corrects the argument in usb_ep_free_request as it is
> mistakenly set to ep_out. It should be ep_in for status request.
> 
> Signed-off-by: Manish Narani <mnarani@xilinx.com>
> ---
>  drivers/usb/gadget/function/f_tcm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
> index d235113..a82e2bd 100644
> --- a/drivers/usb/gadget/function/f_tcm.c
> +++ b/drivers/usb/gadget/function/f_tcm.c
> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
>  	usb_ep_free_request(fu->ep_in, fu->bot_req_in);
>  	usb_ep_free_request(fu->ep_out, fu->bot_req_out);
>  	usb_ep_free_request(fu->ep_out, fu->cmd.req);
> -	usb_ep_free_request(fu->ep_out, fu->bot_status.req);
> +	usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>  
>  	kfree(fu->cmd.buf);
>  

Applied to target-pending/master.

Thanks!