Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756614AbdCUHeu (ORCPT ); Tue, 21 Mar 2017 03:34:50 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36202 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669AbdCUHeW (ORCPT ); Tue, 21 Mar 2017 03:34:22 -0400 Date: Tue, 21 Mar 2017 08:27:00 +0100 From: Daniel Vetter To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] drm: Clarify the role of plane_state argument to drm_simple update(). Message-ID: <20170321072700.l3tjviffdq3abovb@phenom.ffwll.local> Mail-Followup-To: Eric Anholt , dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, Russell King , linux-kernel@vger.kernel.org References: <20170320233615.5242-1-eric@anholt.net> <20170320233615.5242-3-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320233615.5242-3-eric@anholt.net> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2357 Lines: 64 On Mon, Mar 20, 2017 at 04:36:15PM -0700, Eric Anholt wrote: > Like the atomic update hook it's wrapping, the plane_state is the old > one, and the new one is in plane->state. Both msxfb and tinydrm use > it correctly, but I mistook it for the new state in pl111 due to its > naming. > > Signed-off-by: Eric Anholt We could do the same rename in mxsfb, and maybe extend the kernel-doc a bit more to document the parameters. But this is a good change already, so Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_simple_kms_helper.c | 4 ++-- > include/drm/drm_simple_kms_helper.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c > index 16789faa9291..e084f9f8ca66 100644 > --- a/drivers/gpu/drm/drm_simple_kms_helper.c > +++ b/drivers/gpu/drm/drm_simple_kms_helper.c > @@ -114,7 +114,7 @@ static int drm_simple_kms_plane_atomic_check(struct drm_plane *plane, > } > > static void drm_simple_kms_plane_atomic_update(struct drm_plane *plane, > - struct drm_plane_state *pstate) > + struct drm_plane_state *old_pstate) > { > struct drm_simple_display_pipe *pipe; > > @@ -122,7 +122,7 @@ static void drm_simple_kms_plane_atomic_update(struct drm_plane *plane, > if (!pipe->funcs || !pipe->funcs->update) > return; > > - pipe->funcs->update(pipe, pstate); > + pipe->funcs->update(pipe, old_pstate); > } > > static int drm_simple_kms_plane_prepare_fb(struct drm_plane *plane, > diff --git a/include/drm/drm_simple_kms_helper.h b/include/drm/drm_simple_kms_helper.h > index fffbb95a0915..2d36538e4a17 100644 > --- a/include/drm/drm_simple_kms_helper.h > +++ b/include/drm/drm_simple_kms_helper.h > @@ -72,7 +72,7 @@ struct drm_simple_display_pipe_funcs { > * the hardware lacks vblank support entirely. > */ > void (*update)(struct drm_simple_display_pipe *pipe, > - struct drm_plane_state *plane_state); > + struct drm_plane_state *old_plane_state); > > /** > * @prepare_fb: > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch