Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756933AbdCUIHE (ORCPT ); Tue, 21 Mar 2017 04:07:04 -0400 Received: from keymaster.Cadence.COM ([158.140.2.26]:33682 "EHLO mx-sanjose5.cadence.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756899AbdCUIHC (ORCPT ); Tue, 21 Mar 2017 04:07:02 -0400 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Date: Tue, 21 Mar 2017 07:19:17 +0000 From: Piotr Sroka Message-ID: <201703210719.v2L7JHLV032698@lvloginb.cadence.com> To: Masahiro Yamada CC: linux-mmc , Adrian Hunter , Ulf Hansson , Linux Kernel Mailing List , Piotr Subject: RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration In-Reply-To: References: <1489754302-10996-1-git-send-email-piotrs@cadence.com> <1489754503-16559-1-git-send-email-piotrs@cadence.com> MIME-Version: 1.0 Content-Type: text/plain X-OrganizationHeadersPreserved: maileu3.global.cadence.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 30 Hi Masahiro, > Hi Piotr, > > 2017-03-20 17:47 GMT+09:00 Piotr Sroka : > > > >> > >> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev) > >> > struct sdhci_cdns_priv *priv; > >> > struct clk *clk; > >> > int ret; > >> > + struct device *dev = &pdev->dev; > >> > > >> > clk = devm_clk_get(&pdev->dev, NULL); > >> > >> > >> If you add "dev", please use it for devm_clk_get, too. > >> > > I did on the first patch version but Ulf pointed that this is unrelated change and should be removed. > > Therefore I remove it. > > Ah, OK. > > Could you consider to send a separate patch for this? > Ok. If v5 is needed I will add additional patch making this modification. If not I will prepare a spearate patch. Best Regards Piotr Sroka