Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757172AbdCUI12 (ORCPT ); Tue, 21 Mar 2017 04:27:28 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:45519 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756175AbdCUI1Z (ORCPT ); Tue, 21 Mar 2017 04:27:25 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: nickey.yang@rock-chips.com X-FST-TO: ck.hu@mediatek.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: nickey.yang@rock-chips.com X-UNIQUE-TAG: <5060034416fb52dff7f6ef8cd0ee63c1> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Nickey Yang To: ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, matthias.bgg@gmail.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, Nickey Yang Subject: [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake Date: Tue, 21 Mar 2017 16:27:03 +0800 Message-Id: <1490084823-3968-1-git-send-email-nickey.yang@rock-chips.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 27 mtk_hdmi_setup_vendor_specific_infoframe will return before handle mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack returns the number of bytes packed into the binary buffer or a negative error code on failure. So correct it. Signed-off-by: Nickey Yang --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index c262512..b43aa29 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1062,7 +1062,7 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi, } err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer)); - if (err) { + if (err < 0) { dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n", err); return err; -- 1.9.1