Date: Tue, 21 Mar 2017 10:27:56 +0100
From: Petr Tesarik <ptesarik@suse.cz>
To: Xunlei Pang <xlpang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
        Baoquan He <bhe@redhat.com>, Eric Biederman <ebiederm@xmission.com>,
        akpm@linux-foundation.org, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH v3 1/3] kexec: Move vmcoreinfo out of the kernel's .bss
 section
Message-ID: <20170321102756.795fe8ae@hananiah.suse.cz>
In-Reply-To: <1489989033-1179-1-git-send-email-xlpang@redhat.com>
References: <1489989033-1179-1-git-send-email-xlpang@redhat.com>
Organization: SUSE Linux, s.r.o.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 808
Lines: 20

On Mon, 20 Mar 2017 13:50:31 +0800
Xunlei Pang <xlpang@redhat.com> wrote:

> As Eric said,
> "what we need to do is move the variable vmcoreinfo_note out
> of the kernel's .bss section.  And modify the code to regenerate
> and keep this information in something like the control page.
> 
> Definitely something like this needs a page all to itself, and ideally
> far away from any other kernel data structures.  I clearly was not
> watching closely the data someone decided to keep this silly thing
> in the kernel's .bss section."
> 
> This patch allocates extra pages for these vmcoreinfo_XXX variables,
> one advantage is that it enhances some safety of vmcoreinfo, because
> vmcoreinfo now is kept far away from other kernel data structures.

Yes, I like this patch set very much now. Thank you!

Petr T