Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756711AbdCUKha (ORCPT ); Tue, 21 Mar 2017 06:37:30 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33121 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756186AbdCUKh2 (ORCPT ); Tue, 21 Mar 2017 06:37:28 -0400 MIME-Version: 1.0 In-Reply-To: <20170320184253.4858.12956.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <20170320182014.4858.22352.stgit@bhelgaas-glaptop.roam.corp.google.com> <20170320184253.4858.12956.stgit@bhelgaas-glaptop.roam.corp.google.com> From: Geert Uytterhoeven Date: Tue, 21 Mar 2017 11:37:11 +0100 X-Google-Sender-Auth: HeTWYusCOIUFAfL8iPtGLzDMH7I Message-ID: Subject: Re: [PATCH v2 2/4] asm-generic/io.h: Remove unused generic __ioremap() definition To: Bjorn Helgaas Cc: Arnd Bergmann , Michael Ellerman , Linux-Arch , linux-pci , "Luis R. Rodriguez" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2LAbYSf017703 Content-Length: 1364 Lines: 37 Hi Björn, On Mon, Mar 20, 2017 at 7:42 PM, Bjorn Helgaas wrote: > Several arches use __ioremap() to help implement the generic ioremap(), > ioremap_nocache(), and ioremap_wc() interfaces, but this usage is all > inside the arch/ directory. > > The only __ioremap() uses outside arch/ are in the ZorroII RAM disk driver > and some framebuffer drivers that are only buildable on m68k and powerpc, > and they use the versions provided by those arches. > > There's no need for a generic version of __ioremap(), so remove it. These all predate the ioremap_*() variants, and can be converted to either ioremap_nocache() or ioremap_wt(). However, PPC doesn't implement ioremap_wt() yet, so asm-generic will fall back to the less-efficient nocache variant. PPC does support __ioremap(..., _PAGE_WRITETHRU), so adding a wrapper is trivial. > Signed-off-by: Bjorn Helgaas > Reviewed-by: Arnd Bergmann Regardless, Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds