Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757021AbdCUKhu (ORCPT ); Tue, 21 Mar 2017 06:37:50 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:3947 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756796AbdCUKhn (ORCPT ); Tue, 21 Mar 2017 06:37:43 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 21 Mar 2017 03:37:41 -0700 Subject: Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack To: Viresh Kumar , Stephen Warren , Thierry Reding , "Alexandre Courbot" References: <3fe40fcd427e49cbeac31e14721fea569d230b6e.1490073884.git.viresh.kumar@linaro.org> CC: , , From: Jon Hunter Message-ID: <7d0425c1-de9a-cb1a-fde7-71e903579562@nvidia.com> Date: Tue, 21 Mar 2017 10:37:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <3fe40fcd427e49cbeac31e14721fea569d230b6e.1490073884.git.viresh.kumar@linaro.org> X-Originating-IP: [10.21.132.151] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 615 Lines: 18 On 21/03/17 05:24, Viresh Kumar wrote: > The size of the struct tegra_powergate is quite big and if any more > fields are added to the internal genpd structure, following warnings are > thrown: > > drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] Hmmm ... AFAICT the size of the tegra_powergate struct is 312 bytes (based upon next-20170321) and so it looks like something massive needs to be added to the genpd struct to blow this up to over 1024 bytes. Are there some genpd changes in-flight that are causing this? Cheers Jon -- nvpublic