Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756753AbdCUKj4 (ORCPT ); Tue, 21 Mar 2017 06:39:56 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:33333 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756170AbdCUKjy (ORCPT ); Tue, 21 Mar 2017 06:39:54 -0400 Date: Tue, 21 Mar 2017 16:09:50 +0530 From: Viresh Kumar To: Jon Hunter Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , linaro-kernel@lists.linaro.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack Message-ID: <20170321103950.GS25659@vireshk-i7> References: <3fe40fcd427e49cbeac31e14721fea569d230b6e.1490073884.git.viresh.kumar@linaro.org> <7d0425c1-de9a-cb1a-fde7-71e903579562@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d0425c1-de9a-cb1a-fde7-71e903579562@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 21 On 21-03-17, 10:37, Jon Hunter wrote: > > On 21/03/17 05:24, Viresh Kumar wrote: > > The size of the struct tegra_powergate is quite big and if any more > > fields are added to the internal genpd structure, following warnings are > > thrown: > > > > drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Hmmm ... AFAICT the size of the tegra_powergate struct is 312 bytes > (based upon next-20170321) and so it looks like something massive needs > to be added to the genpd struct to blow this up to over 1024 bytes. Are > there some genpd changes in-flight that are causing this? https://marc.info/?l=linux-kernel&m=149000247329743&w=2 This is up for discussion right now though and we don't know if it will surely get merged or not. -- viresh