Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757058AbdCULIQ (ORCPT ); Tue, 21 Mar 2017 07:08:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47724 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755005AbdCULIO (ORCPT ); Tue, 21 Mar 2017 07:08:14 -0400 Date: Tue, 21 Mar 2017 11:08:04 +0000 From: Mark Brown To: Jeremy Linton Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, puck.chen@hisilicon.com, lee.jones@linaro.org Message-ID: <20170321110804.qlyqqiuunrpuklqu@sirena.org.uk> References: <20170321045341.4833-1-lintonrjeremy@gmail.com> <20170321045341.4833-3-lintonrjeremy@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ypakqsayy3kxth5b" Content-Disposition: inline In-Reply-To: <20170321045341.4833-3-lintonrjeremy@gmail.com> X-Cookie: No shirt, no shoes, no service. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] regulator: hi655x: Bump parent pmic module use count X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 32 --ypakqsayy3kxth5b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 20, 2017 at 11:53:41PM -0500, Jeremy Linton wrote: > + if (!try_module_get(parent->driver->owner)) { > + dev_err(&pdev->dev, "unable to get parent module\n"); > + return -ENODEV; > + } > + If this makes sense it should be being done in the driver core, not open coded in individual drivers. --ypakqsayy3kxth5b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljRCZQACgkQJNaLcl1U h9Av7Qf/duw5+hmEheKY7V4Ol0GcVUOdyQDsYlOoOxBy6UFuj/YnXlritaSxizdN WWtGlTJCQDnsT8LANTKimiqbKYGTL+EDcfQg/um74AaW4CwNOLsXgUGG46fkVPZu HuxyOIM02Ub9HrWwA/xgui3wnV3OlW8JcO6x7oAHbU+V46+ICVLmGwgRMXSYrj0+ kZauqPqjOFYhTeL6ka8jyo4pxmAb+2BcC+dHMGLJPpkYXo7XDn0qg6ckAdnVb/qy 6LRlgSDsK1SUumVVAIEmKwAv63aGQcFHmuK+5KxMUrO+r3HNfSBFU2g16HjSbI88 GoGJ7bo9yMbCVhjsXbCAz2/GpvGdPg== =DZXp -----END PGP SIGNATURE----- --ypakqsayy3kxth5b--