Date: Tue, 21 Mar 2017 13:49:12 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Adam Borowski <kilobyte@angband.pl>
cc: Ingo Molnar <mingo@kernel.org>, Andrei Vagin <avagin@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Dmitry Safonov <dsafonov@virtuozzo.com>,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Garnier <thgarnie@google.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: linux-next: x86: Unalbe to run x32 processes on the x86_64
 kernel
In-Reply-To: <20170321075934.o4sccpawzn4rmtvh@angband.pl>
Message-ID: <alpine.DEB.2.20.1703211339200.3617@nanos>
References: <CANaxB-yGu9yWuFyeuZGyKP-0KGDamfoxpiVYo2fSoi3p4qSULw@mail.gmail.com> <CANaxB-xWX+e9VdO4wJfC3Mr=spLNmd2Gyc7qTH6_L5PfY-qHRQ@mail.gmail.com> <20170321064539.GB30094@gmail.com> <20170321075934.o4sccpawzn4rmtvh@angband.pl>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 953
Lines: 29

On Tue, 21 Mar 2017, Adam Borowski wrote:
> On Tue, Mar 21, 2017 at 07:45:39AM +0100, Ingo Molnar wrote:
> > * Andrei Vagin <avagin@gmail.com> wrote:
> > 
> > > # first bad commit: [45fc8757d1d2128e342b4e7ef39adedf7752faac] x86:
> > > Make the GDT remapping read-only on 64-bit
> > 
> > Just wondering, does the following commit fix it:
> > 
> >   5b781c7e317f x86/tls: Forcibly set the accessed bit in TLS segments
> 
> It does fix i386 but not x32.
> 
> By "x32" I mean CONFIG_X86_X32, by "i386" CONFIG_IA32_EMULATION, contrary to
> Andrei's first report.  The naming of the new ABI wasn't too fortunate...

The X32 issue is unrelated to the GDT mapping.

What happens is that the mmap rework from Dmitry switched X32 to use 64bit
mappings, which is wrong. X32 has 64bit instructions and syscalls and 32bit
address space.

Dmitry, can you please have a look and fix that up? For reproduction just
compile helloworld.c with gcc -mx32.

Thanks,

	tglx