Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbdCUNfq (ORCPT ); Tue, 21 Mar 2017 09:35:46 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59943 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdCUNfo (ORCPT ); Tue, 21 Mar 2017 09:35:44 -0400 Subject: Re: Conversion of w83627ehf to hwmon_device_register_with_info ? To: =?UTF-8?Q?Peter_H=c3=bcwe?= References: <201703030133.01363.PeterHuewe@gmx.de> <201703211146.24674.PeterHuewe@gmx.de> Cc: linux-hwmon@vger.kernel.org, Jean Delvare , linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <0163376b-88af-d937-f29b-1d92ac1f87ef@roeck-us.net> Date: Tue, 21 Mar 2017 06:35:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201703211146.24674.PeterHuewe@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 51 On 03/21/2017 03:46 AM, Peter H?we wrote: > Hi > > On Friday 03 March 2017 03:56:01 Guenter Roeck wrote: >> Hi Peter, >> >> On 03/02/2017 04:33 PM, Peter H?we wrote: >>> Hi, >>> >>> is anybody else working on the conversion of the w83627ehf to the new >>> hwmon_device_register_with_info interface? >> >> I don't think so. >> >>> Otherwise I will probably update the driver to this interface within the >>> next days - but since it's a lot of work I wanted to check for >>> duplication first. >> >> Go ahead. > > So I'm close to have to conversion done, > the current diff stat is about > 647 insertions(+), 787 deletions(-) > for the whole conversion. > > Should I try to break it down into smaller chunks for easier review? > > Although this would mean to convert stuff from A to B and then from B to C - > otherwise the intermediate steps would be not fully functional. > (since the sysfs nodes partially would exist under hwmon1/ and partially under > hwmon1/device/ (as they currently are)). > > or just submit it? > Just submit it. I don't really think a conversion like this can be split up cleanly. > It saves about 20k in compiled size, so the savings from reduced boilerplate > are huge. (and I think it's more readable) > >> I would suggest to drop nct6775/nct6776 support to simplify the >> code when you do that. Maybe as separate commit, though. > Hehe - I'm testing on a nct6776 :) > I'll look into it once the first conversion has been accepted. > Wondering - why don't you use the nct6775 driver ? Thanks, Guenter