Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932844AbdCUO06 (ORCPT ); Tue, 21 Mar 2017 10:26:58 -0400 Received: from mail-ot0-f173.google.com ([74.125.82.173]:36535 "EHLO mail-ot0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757240AbdCUO0z (ORCPT ); Tue, 21 Mar 2017 10:26:55 -0400 MIME-Version: 1.0 In-Reply-To: <20170321140325.gf64gc7eaqu335t5@hirez.programming.kicks-ass.net> References: <4366682.tsferJN35u@aspire.rjw.lan> <2185243.flNrap3qq1@aspire.rjw.lan> <3300960.HE4b3sK4dn@aspire.rjw.lan> <20170321132253.vjp7f72qkubpttmf@hirez.programming.kicks-ass.net> <20170321140325.gf64gc7eaqu335t5@hirez.programming.kicks-ass.net> From: Vincent Guittot Date: Tue, 21 Mar 2017 15:18:55 +0100 Message-ID: Subject: Re: [RFC][PATCH v2 2/2] cpufreq: schedutil: Avoid decreasing frequency of busy CPUs To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Linux PM , LKML , Srinivas Pandruvada , Viresh Kumar , Juri Lelli , Patrick Bellasi , Joel Fernandes , Morten Rasmussen , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 32 On 21 March 2017 at 15:03, Peter Zijlstra wrote: > On Tue, Mar 21, 2017 at 02:37:08PM +0100, Vincent Guittot wrote: >> On 21 March 2017 at 14:22, Peter Zijlstra wrote: > >> For the not overloaded case, it makes sense to immediately update to >> OPP to be aligned with the new utilization of the CPU even if it was >> not idle in the past couple of ticks > > Yeah, but we cannot know. Also, who cares? embedded system that doesn't want to stay at higest OPP if significant part of the utilzation has moved away as an example AFAICT, schedutil tries to select the best OPP according to the current utilization of the CPU so if the utilization decreases, the OPP should also decrease > >> > does exactly that. Note that the lack of idle time is an exact >> > equivalent of 100% utilized. >> > >> > So even while we cannot currently detect the 100% utilized state through >> > the running state tracking; because averages etc.. we can detect the >> > lack of idle time. >> >> But after how much lack of idle time do we consider that we are overloaded ? > > 0 :-) > > Note that utilization is an absolute metric, not a windowed one. That > is, there is no actual time associated with it. Now, for practical > purposes we end up using windowed things in many places, >