Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758100AbdCUPSS (ORCPT ); Tue, 21 Mar 2017 11:18:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:19630 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757522AbdCUPSQ (ORCPT ); Tue, 21 Mar 2017 11:18:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="238747318" Subject: Re: [PATCH 1/5] x86: Implement __WARN using UD0 To: Peter Zijlstra , Josh Poimboeuf References: <20170317211918.393791494@infradead.org> <20170317212350.828368979@infradead.org> <20170321140340.urru2lmjko6txwl5@treble> <20170321151446.GV3093@worktop> Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, bp@alien8.de, richard.weinberger@gmail.com From: Arjan van de Ven Message-ID: <7cddf309-be53-c556-0919-dfa23ad0512e@linux.intel.com> Date: Tue, 21 Mar 2017 08:17:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170321151446.GV3093@worktop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 236 Lines: 11 On 3/21/2017 8:14 AM, Peter Zijlstra wrote: > For self-documentation purposes, maybe use a define for the length of > the ud0 instruction? #define TWO 2 ;-) some things make sense as a define, others don't (adding a comment, maybe)