Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932923AbdCUQ1s (ORCPT ); Tue, 21 Mar 2017 12:27:48 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:35309 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757688AbdCUQ0k (ORCPT ); Tue, 21 Mar 2017 12:26:40 -0400 MIME-Version: 1.0 In-Reply-To: <20170321161427.103713-1-glider@google.com> References: <20170321161427.103713-1-glider@google.com> From: Soheil Hassas Yeganeh Date: Tue, 21 Mar 2017 12:25:58 -0400 Message-ID: Subject: Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use To: Alexander Potapenko Cc: Dmitry Vyukov , kcc@google.com, Eric Dumazet , David Miller , kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 14 On Tue, Mar 21, 2017 at 12:14 PM, Alexander Potapenko wrote: > In the case udp_sk(sk)->pending is AF_INET6, udpv6_sendmsg() would > jump to do_append_data, skipping the initialization of sockc.tsflags. > Fix the problem by moving sockc.tsflags initialization earlier. > > The bug was detected with KMSAN. Nice catch and thanks for the fix! This is missing a "fixes" attribution, added below. > Signed-off-by: Alexander Potapenko Fixes: c14ac9451c34 ("sock: enable timestamping using control messages") Acked-by: Soheil Hassas Yeganeh