Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933041AbdCUR2a (ORCPT ); Tue, 21 Mar 2017 13:28:30 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:54892 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932744AbdCUR2A (ORCPT ); Tue, 21 Mar 2017 13:28:00 -0400 Date: Tue, 21 Mar 2017 17:27:00 +0000 From: Russell King - ARM Linux To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111 Message-ID: <20170321172700.GC21222@n2100.armlinux.org.uk> References: <20170320233615.5242-1-eric@anholt.net> <20170320233615.5242-2-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320233615.5242-2-eric@anholt.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 36 On Mon, Mar 20, 2017 at 04:36:14PM -0700, Eric Anholt wrote: > +static struct amba_driver pl111_amba_driver = { > + .drv = { > + .name = "clcd-pl11x", either: .name = "clcd-pl111", or: .name = "drm-clcd-pl111", otherwise the driver names will clash in sysfs - driver names must be unique. > + }, > + .probe = pl111_amba_probe, > + .remove = pl111_amba_remove, > + .id_table = pl111_id_table, > +}; > +#endif /* CONFIG_ARM_AMBA */ > + > +module_amba_driver(pl111_amba_driver); > + > +MODULE_DESCRIPTION(DRIVER_DESC); > +MODULE_AUTHOR("ARM Ltd."); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:pl111_drm"); Does the platform alias make sense for an OF-only driver? -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.