Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932896AbdCURto (ORCPT ); Tue, 21 Mar 2017 13:49:44 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:50003 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757341AbdCURtF (ORCPT ); Tue, 21 Mar 2017 13:49:05 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v2LHmkWj026371 X-Nifty-SrcIP: [209.85.161.170] MIME-Version: 1.0 In-Reply-To: <20170320171553.GB23333@glebfm.cloud.tilaa.com> References: <20170310162411.GA18175@glebfm.cloud.tilaa.com> <20170310120422.14e19269@gandalf.local.home> <20170310173952.GW27556@glebfm.cloud.tilaa.com> <20170310124210.5f52305f@gandalf.local.home> <20170310175536.GX27556@glebfm.cloud.tilaa.com> <20170320171553.GB23333@glebfm.cloud.tilaa.com> From: Masahiro Yamada Date: Wed, 22 Mar 2017 02:48:44 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PING PATCH v2] jump label: fix passing kbuild_cflags when checking for asm goto support To: Gleb Fotengauer-Malinovskiy Cc: Steven Rostedt , David Lin , "Anton V. Boyarshinov" , "Dmitry V. Levin" , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1941 Lines: 48 2017-03-21 2:15 GMT+09:00 Gleb Fotengauer-Malinovskiy : > The latest change of asm goto support check added passing of KBUILD_CFLAGS > to compiler. When these flags reference gcc plugins that are not built yet, > the check fails. > > When one runs "make bzImage" followed by "make modules", the kernel is always > built with HAVE_JUMP_LABEL disabled, while the modules are built depending on > CONFIG_JUMP_LABEL. If HAVE_JUMP_LABEL macro happens to be different, modules > are built with undefined references, e.g.: > > ERROR: "static_key_slow_inc" [net/netfilter/xt_TEE.ko] undefined! > ERROR: "static_key_slow_dec" [net/netfilter/xt_TEE.ko] undefined! > ERROR: "static_key_slow_dec" [net/netfilter/nft_meta.ko] undefined! > ERROR: "static_key_slow_inc" [net/netfilter/nft_meta.ko] undefined! > ERROR: "nf_hooks_needed" [net/netfilter/ipvs/ip_vs.ko] undefined! > ERROR: "nf_hooks_needed" [net/ipv6/ipv6.ko] undefined! > ERROR: "static_key_count" [net/ipv6/ipv6.ko] undefined! > ERROR: "static_key_slow_inc" [net/ipv6/ipv6.ko] undefined! > > This change moves the check before all these references are added > to KBUILD_CFLAGS. This is correct because subsequent KBUILD_CFLAGS > modifications are not relevant to this check. > > Reported-by: Anton V. Boyarshinov > Fixes: 35f860f9ba6a ("jump label: pass kbuild_cflags when checking for asm goto support") > Cc: stable@vger.kernel.org # v4.10 > Signed-off-by: Gleb Fotengauer-Malinovskiy > Signed-off-by: Dmitry V. Levin > Acked-by: Steven Rostedt (VMware) > Acked-by: David Lin > --- > v2: update description of the problem fixed by this patch > I assume this PING is addressed to me. First, Steven asked Andrew to pick up this, but I have not seen it in linux-next yet. So, Applied to linux-kbuild/fixes. Thanks! -- Best Regards Masahiro Yamada