From: Eric Anholt <eric@anholt.net>
To: Michael Zoran <mzoran@crowfest.net>, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-rpi-kernel@lists.infradead.org,
        Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3
In-Reply-To: <1490071342.11105.22.camel@crowfest.net>
References: <20170317152221.8381-1-mzoran@crowfest.net> <20170317152221.8381-2-mzoran@crowfest.net> <294780758.583819.1489843404003@email.1und1.de> <1489898563.1536.1.camel@crowfest.net> <456494443.511096.1489919984010@email.1und1.de> <1489923494.4316.1.camel@crowfest.net> <1687987180.514561.1489934830943@email.1und1.de> <1489941033.13607.3.camel@crowfest.net> <87a88fsw0t.fsf@eliezer.anholt.net> <1490071342.11105.22.camel@crowfest.net>
User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Tue, 21 Mar 2017 10:34:08 -0700
Message-ID: <874lym3567.fsf@eliezer.anholt.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3933
Lines: 102

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Michael Zoran <mzoran@crowfest.net> writes:

> On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
>> Michael Zoran <mzoran@crowfest.net> writes:
>>=20
>> > > > Since the API is completely documented, I see no reason we or
>> > > > anybody
>> > > > couldn't essentially rewrite the driver while it's in
>> > > > staging.=C2=A0=C2=A0I
>> > > > just
>> > > > think it would be best for everyone if the new version was a
>> > > > drop
>> > > > in
>> > > > replacement for the original version.=C2=A0=C2=A0Essential an enha=
ncement
>> > > > rather
>> > > > then a competitor.
>> > >=20
>> > > I think my comments weren't fundamental changes, but you surely
>> > > mean
>> > > the devicetree ABI? I like to see this driver ASAP out of staging
>> > > and
>> > > i'm not interested to maintain 2 functional identical driver only
>> > > to
>> > > keep compability with the Foundation tree. Currently i'm afraid
>> > > that
>> > > we build up many drivers in staging, which need a complete
>> > > rewrite
>> > > later if they should come out of staging. It would be nice if we
>> > > could avoid the situation we have with the thermal driver.
>> > >=20
>> > > Stefan
>> >=20
>> > The API I'm talking about here is the mailbox API that is used to
>> > talk
>> > to the firmware.=C2=A0=C2=A0The numbers and structures to pass are
>> > documented.=C2=A0
>> > Nothing prevents anybody from rewriting this driver and submitting
>> > it
>> > to the appropriate subsystems.=C2=A0=C2=A0It's certainly small enough.
>> >=20
>> > If you really want working thermal or cpu speed drivers today,
>> > nothing
>> > stops anybody from submitting the downstream drivers after doing
>> > some
>> > minor touchups and submitting them to staging.=C2=A0=C2=A0That would a=
t least
>> > get
>> > things working while people argue about what the correct DT nodes
>> > should be.
>> >=20
>> > I would also like to point out that the RPI 3 has been out for over
>> > a
>> > year and nobody has been able to get working video out of it
>> > through
>> > VC4 on a mainline tree.=C2=A0=C2=A0At least until now.=C2=A0=C2=A0So I=
'm not sure the
>> > best
>> > way to go is for the expander driver to go under the GPIO subtree.
>>=20
>> Excuse me?=C2=A0=C2=A0Display works fine on my Pi3.=C2=A0=C2=A0VC4 uses =
DDC to probe for
>> connection when the GPIO line isn't present in the DT.
>
> Just a FYI, Eric Anholt has offically announced support for VC4 for
> HDMI on mainline Linus build without any support from the expander on
> the RPI 3.=20=20
>
> Sounds like this particular driver isn't needed then, correct?

That's the HDMI audio that just landed.  HDMI has been working on the
pi3 since 9d44abbbb8d530e8cc97d71ffcbc0ff3b5553c62.

In the absence of a GPIO line for hotplug detect, we use DDC, which is
slower and throws an error in dmesg when the probe happens but HDMI is
disconnected.  As such, having a GPIO driver would improve things for
people.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljRZBAACgkQtdYpNtH8
nuir1g/7BeVOV1Biyj75NGGeTlfMy/8uJXkVvl2pcLV6Ud5YTm0MPllEMYljz8eF
IjeTouaBT5OVhI/pqAfCbM1LTna8/dnAzsq3BrtnbnBtQZQ8OuA/sstIkU/CKpiP
cI35UBlXanEBrbzJRcAfUNyCfXyJ7wsQQ9hzSziJT28k8DA2Zf/qDrtZNkEqvvO7
Es0bWlCLemTZCsIJ2OnhNmAW44Yx2u8Wy/Sq7usgGzLypS6kGKa5TdGGAFnAVVp7
OOwsfCeLY9YlQMIaEGqRPCuEgKuEEbOxbzFZSYDkMmuvf2yQ/IvrFKtLFwVw0hl9
+Dl5n+dh8qai4aRe+JcN/bGjlP3YzD4y5rODrIeliRAGxxQm4wlRK2N+8vINbxcW
kYFfCK0rx85C+rAAnR9KT0OlXSxxiV5e+SdAbE+Ct83gTV099q5hxwahtwVBfTl4
wzNCQa52Mq66WGWuk2igILqFZwCb4s2MpYPLj7RG3cGvXMlRdFyMGeDetC7QjNo1
+ctQ71emnuRXo3pOfd5gtZcTAufTXg1YIHO/UtLtF/iFPFg/jQCA3YfH0VIOoYL4
aJr3jE0pej3+hvTmqW7I7TtQpxcXrvJM8Rn4/JBjkG0bGmR2hVyiGNbszDklL9Ie
PJzHxhm9euMwoA/pEUeK3dkED5ag+sYzCy3ll4Xfnx69zUrnNYc=
=nCzV
-----END PGP SIGNATURE-----
--=-=-=--