Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758239AbdCUSjf (ORCPT ); Tue, 21 Mar 2017 14:39:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:34680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757822AbdCUSjc (ORCPT ); Tue, 21 Mar 2017 14:39:32 -0400 Date: Tue, 21 Mar 2017 15:32:29 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu , Jiri Olsa Subject: Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Message-ID: <20170321183229.GF3641@kernel.org> References: <1489978617-31396-1-git-send-email-treeze.taeung@gmail.com> <1489978617-31396-5-git-send-email-treeze.taeung@gmail.com> <20170321143728.GD3641@kernel.org> <80581369-94ad-b921-174e-5b981126ccf0@gmail.com> <20170321182950.GE3641@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321182950.GE3641@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 24 Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: > > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: > > > > +++ b/tools/perf/util/annotate.c > > > > @@ -1443,7 +1443,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na > > > > snprintf(command, sizeof(command), > > > > "%s %s%s --start-address=0x%016" PRIx64 > > > > " --stop-address=0x%016" PRIx64 > > > > - " -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand", > > > > + " -l -d %s %s -C %s 2>/dev/null|grep -v %s: |expand", > > > > Are you sure this works as you expect? I.e. both lines will have '%s:' > > > Yes, if we do, we can exactly the only below line without the side effect > > IMHO. > > yeah, because the .c is not there, ok gotcha, will get your new commit > log message, massage it a bit and apply the patch. Nah, with all this in mind, the original message is good enough, sorry for the confusion with the .c and the space after ':' (that I removed, needless and potentially confusing, as we saw here). - Arnaldo