Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933888AbdCUSwD (ORCPT ); Tue, 21 Mar 2017 14:52:03 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:45990 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933146AbdCUSvy (ORCPT ); Tue, 21 Mar 2017 14:51:54 -0400 Date: Tue, 21 Mar 2017 19:51:47 +0100 (CET) From: Thomas Gleixner To: Steven Rostedt cc: lionel.debieve@st.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, Patrice Chotard , Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware In-Reply-To: <20170321144437.569440c2@vmware.local.home> Message-ID: References: <1490112340-29772-1-git-send-email-lionel.debieve@st.com> <20170321144437.569440c2@vmware.local.home> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 21 On Tue, 21 Mar 2017, Steven Rostedt wrote: > > /* > > * Disable interrupts so we don't get the IRQ line bouncing > > I'm nervous about the above comment, which in full is: > > /* > * Disable interrupts so we don't get the IRQ line bouncing > * up and down while interrupts are disabled. > */ > > I'm not sure if disabling interrupts helps on an SMP system. This patch > does change what happens when port->sysrq is set. But I'm not sure we > care. It disables interrupts at the device level which obviously helps whether on SMP or not. Thanks, tglx