Message-ID: <1490121068.2041.13.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent
 spurious warnings
From: Joe Perches <joe@perches.com>
To: "John 'Warthog9' Hawley (VMware)" <warthog9@eaglescrag.net>,
        linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>,
        "Darren Hart (VMware)" <dvhart@infradead.org>
Date: Tue, 21 Mar 2017 11:31:08 -0700
In-Reply-To: <1490113805-9295-1-git-send-email-warthog9@eaglescrag.net>
References: <1490113805-9295-1-git-send-email-warthog9@eaglescrag.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 33

On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote:
> Spamassassin sticks a long (~79 character) long string after a
> line that has a single space in it. The line with space causes
> checkpatch to erroniously think that it's in the content body, as
> opposed to headers and thus flag a mail header as an unwrapped long
> comment line.

If the spammassassin header is like

email-header-n: foo
email-header-m: bar
 
X-Spam-Report: bar

Does that form follow rfc 5322?

If it does then any email header could have that
form and the header wrapping test should be
updated from

		if ($in_header_lines && $realfile =~ /^$/ &&
		????!($rawline =~ /^\s+\S/ ||
		??????$rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {
			$in_header_lines = 0;
			$in_commit_log = 1;
			$has_commit_log = 1;
		}

to something like

		if ($in_header_lines && $realfile =~ /^$/ &&
		????!($rawline =~ /^ (?:\s*\S|$)/ ||
		      $rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {