From: Eric Anholt <eric@anholt.net>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111
In-Reply-To: <20170321172700.GC21222@n2100.armlinux.org.uk>
References: <20170320233615.5242-1-eric@anholt.net> <20170320233615.5242-2-eric@anholt.net> <20170321172700.GC21222@n2100.armlinux.org.uk>
User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Tue, 21 Mar 2017 12:41:51 -0700
Message-ID: <87zige1kow.fsf@eliezer.anholt.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1866
Lines: 62

--=-=-=
Content-Type: text/plain

Russell King - ARM Linux <linux@armlinux.org.uk> writes:

> On Mon, Mar 20, 2017 at 04:36:14PM -0700, Eric Anholt wrote:
>> +static struct amba_driver pl111_amba_driver = {
>> +	.drv = {
>> +		.name = "clcd-pl11x",
>
> either:
>
> 		.name = "clcd-pl111",
>
> or:
>
> 		.name = "drm-clcd-pl111",
>
> otherwise the driver names will clash in sysfs - driver names must be
> unique.
>
>> +	},
>> +	.probe = pl111_amba_probe,
>> +	.remove = pl111_amba_remove,
>> +	.id_table = pl111_id_table,
>> +};
>> +#endif /* CONFIG_ARM_AMBA */
>> +
>> +module_amba_driver(pl111_amba_driver);
>> +
>> +MODULE_DESCRIPTION(DRIVER_DESC);
>> +MODULE_AUTHOR("ARM Ltd.");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:pl111_drm");
>
> Does the platform alias make sense for an OF-only driver?

Not sure, this is left over from the original submission.

If I renamed to drm-clcd-pl111 and dropped the alias, would that get
your ack?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljRgf8ACgkQtdYpNtH8
nujmUQ/+MunthH/vRBsSmHiptNzmBJf/5K29bJcd1oxQT3Uk/82+0YMD4dZNqpan
HvKFM54Gm5RVQDaBhystg116IJfnAN/8GFGmZ/I48k0m09PNaYLsAZJfIB+WX7A6
QDnwGSlTZWtEyxTLHK7NQE14moPR935Th+brypAs6JMamLBX0yUidjRSYSgmabfD
svhS1vELZd/io/aelCfcneboe2CoS/CGScDpNENO7jw58QW5XQ6WBQWSWPK/rR93
Yhew/k2MnY2sf1OIaKQuoFQi63Yt1CYytULj98chXR8AVW/y6UQBfyCdggyrQESD
UdRCUXxuRlQc2D5ccp4gaj3N51JWaRSIoKkdXOf2Y8HP70GvxENjiDrMHqPc438f
FTCtg05EuEo4gBgMpyQNV2Yn7LmjmA+HdoJfzMHlss7pehjrS6FeC1/uJw/p64pq
9HJM8IBtw9r8kuW7G5bFWVSyBtBwO0JrOBcoNbzR1/Jkk6AzM9f6O/xGe9Ydbs6C
tFrTSjIqTYWFdJQyW3cF6d6ly6JmQiQay5kxmpA/ElNgRXy/bTbb7NalFoZRmGk/
tH9eNBdmOBycu6rjAjDf1S+GS9v8OBEUFMnmWcB83QJhXIy8MmXmV94bpT2DS/p5
2xUbebWPHOVP8rKjnHgatV6B3VHEJUsoT7oJ6eCPNgnMr4mMDsE=
=UXHw
-----END PGP SIGNATURE-----
--=-=-=--