Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933514AbdCUU1n (ORCPT ); Tue, 21 Mar 2017 16:27:43 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:34032 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932552AbdCUU1m (ORCPT ); Tue, 21 Mar 2017 16:27:42 -0400 Date: Tue, 21 Mar 2017 16:27:38 -0400 From: Sean Paul To: Chris Zhong Cc: linux-rockchip@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/4] dt-bindings: add the grf clock for dw-mipi-dsi Message-ID: <20170321202738.GI19389@art_vandelay> References: <1489722865-22122-1-git-send-email-zyw@rock-chips.com> <1489722865-22122-3-git-send-email-zyw@rock-chips.com> <20170321201700.GG19389@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321201700.GG19389@art_vandelay> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2112 Lines: 57 On Tue, Mar 21, 2017 at 04:17:00PM -0400, Sean Paul wrote: > On Fri, Mar 17, 2017 at 11:54:22AM +0800, Chris Zhong wrote: > > For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > > add the description for this clock. > > > > Signed-off-by: Chris Zhong > > --- > > > > Changes in v3: None > > Changes in v2: None > > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > > index 188f6f7..7e17a60 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > > @@ -10,7 +10,7 @@ Required properties: > > - interrupts: Represent the controller's interrupt to the CPU(s). > > - clocks, clock-names: Phandles to the controller's pll reference > > clock(ref) and APB clock(pclk). For RK3399, a phy config clock > > - (phy_cfg) is additional required. As described in [1]. > > + (phy_cfg) and a grf clock(grf) are additional required. As described in [1]. > > These are only required for rk3399, you should make that clear. > I completely missed "For RK3399" on my first pass, sigh. Sorry for the reading comprehension fail. Minor nit if you want: s/additional// && s/. As/, as/ Either way, Reviewed-by: Sean Paul Sean > Sean > > > - rockchip,grf: this soc should set GRF regs to mux vopl/vopb. > > - ports: contain a port node with endpoint definitions as defined in [2]. > > For vopb,set the reg = <0> and set the reg = <1> for vopl. > > -- > > 2.6.3 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Sean Paul, Software Engineer, Google / Chromium OS -- Sean Paul, Software Engineer, Google / Chromium OS