Date: Tue, 21 Mar 2017 23:34:39 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: hpa@zytor.com
cc: Dmitry Safonov <dsafonov@virtuozzo.com>, linux-kernel@vger.kernel.org,
        0x7f454c46@gmail.com, Adam Borowski <kilobyte@angband.pl>,
        linux-mm@kvack.org, Andrei Vagin <avagin@gmail.com>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Borislav Petkov <bp@suse.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCHv3] x86/mm: set x32 syscall bit in SET_PERSONALITY()
In-Reply-To: <26CDE83A-CDBE-4F23-91F6-05B07B461BDD@zytor.com>
Message-ID: <alpine.DEB.2.20.1703212327170.3776@nanos>
References: <20170321174711.29880-1-dsafonov@virtuozzo.com> <alpine.DEB.2.20.1703212319440.3776@nanos> <26CDE83A-CDBE-4F23-91F6-05B07B461BDD@zytor.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 661
Lines: 25

On Tue, 21 Mar 2017, hpa@zytor.com wrote:

> On March 21, 2017 3:21:13 PM PDT, Thomas Gleixner <tglx@linutronix.de> wrote:
> >On Tue, 21 Mar 2017, Dmitry Safonov wrote:
> >> v3:
> >> - clear x32 syscall flag during x32 -> x86-64 exec() (thanks, HPA).
> >
> >For correctness sake, this wants to be cleared in the IA32 path as
> >well. It's not causing any harm, but ....
> >
> >I'll amend the patch.
> >
> >Thanks,
> >
> >	tglx
>
> Since the i386 syscall namespace is totally separate (and different),
> should we simply change the system call number to the appropriate
> sys_execve number?

That should work as well and would be more intuitive.

Thanks,

	tglx