Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758513AbdCUXdi (ORCPT ); Tue, 21 Mar 2017 19:33:38 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:36781 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758487AbdCUXdf (ORCPT ); Tue, 21 Mar 2017 19:33:35 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Jerome Brunet , "Stephen Boyd" , "Kevin Hilman" , "Carlo Caione" From: Michael Turquette In-Reply-To: <20170309104154.28295-7-jbrunet@baylibre.com> Cc: "Jerome Brunet" , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170309104154.28295-1-jbrunet@baylibre.com> <20170309104154.28295-7-jbrunet@baylibre.com> Message-ID: <149013840504.54062.12985141705597897606@resonance> User-Agent: alot/0.3.7 Subject: Re: [PATCH v2 6/9] clk: meson: gxbb: mpll: use rw operation Date: Tue, 21 Mar 2017 16:20:05 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2LNZ37M026939 Content-Length: 1669 Lines: 49 Quoting Jerome Brunet (2017-03-09 02:41:51) > Use read/write operations for the mpll clocks instead of the > read-only ones. > > Signed-off-by: Jerome Brunet Looks good to me. Regards, Mike > --- > drivers/clk/meson/gxbb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c > index 79fb8989f8dd..5059c7bbdbb3 100644 > --- a/drivers/clk/meson/gxbb.c > +++ b/drivers/clk/meson/gxbb.c > @@ -459,7 +459,7 @@ static struct meson_clk_mpll gxbb_mpll0 = { > .lock = &clk_lock, > .hw.init = &(struct clk_init_data){ > .name = "mpll0", > - .ops = &meson_clk_mpll_ro_ops, > + .ops = &meson_clk_mpll_ops, > .parent_names = (const char *[]){ "fixed_pll" }, > .num_parents = 1, > }, > @@ -489,7 +489,7 @@ static struct meson_clk_mpll gxbb_mpll1 = { > .lock = &clk_lock, > .hw.init = &(struct clk_init_data){ > .name = "mpll1", > - .ops = &meson_clk_mpll_ro_ops, > + .ops = &meson_clk_mpll_ops, > .parent_names = (const char *[]){ "fixed_pll" }, > .num_parents = 1, > }, > @@ -519,7 +519,7 @@ static struct meson_clk_mpll gxbb_mpll2 = { > .lock = &clk_lock, > .hw.init = &(struct clk_init_data){ > .name = "mpll2", > - .ops = &meson_clk_mpll_ro_ops, > + .ops = &meson_clk_mpll_ops, > .parent_names = (const char *[]){ "fixed_pll" }, > .num_parents = 1, > }, > -- > 2.9.3 >