Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758711AbdCVDXh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Mar 2017 23:23:37 -0400
Received: from out02.mta.xmission.com ([166.70.13.232]:41964 "EHLO
        out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757495AbdCVDXg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Mar 2017 23:23:36 -0400
From: ebiederm@xmission.com (Eric W. Biederman)
To: Dave Young <dyoung@redhat.com>
Cc: Xunlei Pang <xlpang@redhat.com>, Baoquan He <bhe@redhat.com>,
        Petr Tesarik <ptesarik@suse.cz>, kexec@lists.infradead.org,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
References: <1489989033-1179-1-git-send-email-xlpang@redhat.com>
        <87pohbz4lo.fsf@xmission.com>
        <20170322025536.GA4424@dhcp-128-65.nay.redhat.com>
Date: Tue, 21 Mar 2017 22:18:30 -0500
In-Reply-To: <20170322025536.GA4424@dhcp-128-65.nay.redhat.com> (Dave Young's
        message of "Wed, 22 Mar 2017 10:55:36 +0800")
Message-ID: <87pohaxam1.fsf@xmission.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-XM-SPF: eid=1cqWrz-0000ZM-Cg;;;mid=<87pohaxam1.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=67.3.234.240;;;frm=ebiederm@xmission.com;;;spf=neutral
X-XM-AID: U2FsdGVkX1/i136e/9JvBrKyxyU+0lwjekMS5PhqxaQ=
X-SA-Exim-Connect-IP: 67.3.234.240
X-SA-Exim-Mail-From: ebiederm@xmission.com
X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
        *  0.0 TVD_RCVD_IP Message was received from an IP address
        *  0.7 XMSubLong Long Subject
        *  0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available.
        *  0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60%
        *      [score: 0.4517]
        * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC
        *      [sa03 1397; Body=1 Fuz1=1 Fuz2=1]
        *  0.0 T_TooManySym_01 4+ unique symbols in subject
        *  1.0 XM_Sft_Co_L33T No description available.
        *  0.0 T_TooManySym_02 5+ unique symbols in subject
        *  1.0 T_XMDrugObfuBody_00 obfuscated drug references
X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 
X-Spam-Combo: **;Dave Young <dyoung@redhat.com>
X-Spam-Relay-Country: 
X-Spam-Timing: total 670 ms - load_scoreonly_sql: 0.06 (0.0%),
        signal_user_changed: 2.9 (0.4%), b_tie_ro: 1.99 (0.3%), parse: 1.21 (0.2%),
        extract_message_metadata: 5 (0.8%), get_uri_detail_list: 2.3 (0.3%),
        tests_pri_-1000: 6 (0.9%), tests_pri_-950: 2.00 (0.3%), tests_pri_-900: 1.71
        (0.3%), tests_pri_-400: 31 (4.6%), check_bayes: 29 (4.3%), b_tokenize: 11
        (1.6%), b_tok_get_all: 9 (1.3%), b_comp_prob: 4.1 (0.6%), b_tok_touch_all:
        2.5 (0.4%), b_finish: 0.73 (0.1%), tests_pri_0: 591 (88.2%),
        check_dkim_signature: 0.85 (0.1%), check_dkim_adsp: 4.3 (0.6%),
        tests_pri_500: 7 (1.1%), rewrite_mail: 0.00 (0.0%)
Subject: Re: [PATCH v3 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section
X-Spam-Flag: No
X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600)
X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1607
Lines: 38

Dave Young <dyoung@redhat.com> writes:

> On 03/20/17 at 10:33pm, Eric W. Biederman wrote:
>> Xunlei Pang <xlpang@redhat.com> writes:
>> 
>> > As Eric said,
>> > "what we need to do is move the variable vmcoreinfo_note out
>> > of the kernel's .bss section.  And modify the code to regenerate
>> > and keep this information in something like the control page.
>> >
>> > Definitely something like this needs a page all to itself, and ideally
>> > far away from any other kernel data structures.  I clearly was not
>> > watching closely the data someone decided to keep this silly thing
>> > in the kernel's .bss section."
>> >
>> > This patch allocates extra pages for these vmcoreinfo_XXX variables,
>> > one advantage is that it enhances some safety of vmcoreinfo, because
>> > vmcoreinfo now is kept far away from other kernel data structures.
>> 
>> Can you preceed this patch with a patch that removes CRASHTIME from
>> vmcoreinfo?  If someone actually cares we can add a separate note that holds
>> a 64bit crashtime in the per cpu notes.  
>
> I think makedumpfile is using it, but I also vote to remove the
> CRASHTIME. It is better not to do this while crashing and a makedumpfile
> userspace patch is needed to drop the use of it.
>
>> 
>> As we are looking at reliability concerns removing CRASHTIME should make
>> everything in vmcoreinfo a boot time constant.  Which should simplify
>> everything considerably.
>
> It is a nice improvement..

We also need to take a close look at what s390 is doing with vmcoreinfo.
As apparently it is reading it in a different kind of crashdump process.

Eric