Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758767AbdCVFo5 (ORCPT ); Wed, 22 Mar 2017 01:44:57 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36609 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758661AbdCVFos (ORCPT ); Wed, 22 Mar 2017 01:44:48 -0400 Date: Wed, 22 Mar 2017 11:13:15 +0530 From: Gautham R Shenoy To: Nicholas Piggin Cc: "Gautham R. Shenoy" , Michael Ellerman , Michael Neuling , Benjamin Herrenschmidt , "Shreyas B. Prabhu" , Shilpasri G Bhat , Vaidyanathan Srinivasan , Anton Blanchard , Balbir Singh , Akshay Adiga , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 3/4] powernv:idle: Don't override default/deepest directly in kernel Reply-To: ego@linux.vnet.ibm.com References: <84bfbacbd0ab98dd82241292a29e4d5d1bb456c6.1490024477.git.ego@linux.vnet.ibm.com> <20170321023934.1a9b84f6@roar.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321023934.1a9b84f6@roar.ozlabs.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 x-cbid: 17032205-0036-0000-0000-000001BAF8FD X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006826; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00837163; UDB=6.00411528; IPR=6.00614929; BA=6.00005229; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014752; XFM=3.00000013; UTC=2017-03-22 05:43:21 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032205-0037-0000-0000-00003F17155A Message-Id: <20170322054315.GA8326@in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-22_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703220050 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 36 Hi, On Tue, Mar 21, 2017 at 02:39:34AM +1000, Nicholas Piggin wrote: > > @@ -241,8 +240,9 @@ static DEVICE_ATTR(fastsleep_workaround_applyonce, 0600, > > * The default stop state that will be used by ppc_md.power_save > > * function on platforms that support stop instruction. > > */ > > -u64 pnv_default_stop_val; > > -u64 pnv_default_stop_mask; > > +static u64 pnv_default_stop_val; > > +static u64 pnv_default_stop_mask; > > +static bool default_stop_found; > > > > /* > > * Used for ppc_md.power_save which needs a function with no parameters > > @@ -262,8 +262,9 @@ static void power9_idle(void) > > * psscr value and mask of the deepest stop idle state. > > * Used when a cpu is offlined. > > */ > > -u64 pnv_deepest_stop_psscr_val; > > -u64 pnv_deepest_stop_psscr_mask; > > +static u64 pnv_deepest_stop_psscr_val; > > +static u64 pnv_deepest_stop_psscr_mask; > > +static bool deepest_stop_found; > > Aha you have made them static. Nitpick withdrawn :) > > The log messages look good now. > > Reviewed-by: Nicholas Piggin > Thanks! -- Thanks and Regards gautham.